Fix init of device_scalars - #2503
Closed
betatim wants to merge 2 commits into
Closed
Conversation
Zeroed with a device memset. The device_scalar(value, stream) ctor would copy from a host temporary that dies before the copy is guaranteed to have read it.
Unrelated but same type of bug (found by AI).
bdice
approved these changes
Aug 25, 2026
julianmi
pushed a commit
to julianmi/cuvs
that referenced
this pull request
Aug 26, 2026
…#2504) `rapids-cmake` just bumped the commit used for `cuCollections` in builds, leading to `cuvs` build failures. Here we fix usage of `cuco::default_filter_policy` that were changed in NVIDIA/cuCollections#827. Also fixes some fallout from rapidsai/rmm#2527, merging in NVIDIA#2503 (as well as a few small fixups). Closes NVIDIA#2503. Authors: - Jim Crist-Harif (https://github.com/jcrist) - Tim Head (https://github.com/betatim) Approvers: - Divye Gala (https://github.com/divyegala) URL: NVIDIA#2504
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zeroed with a device memset. The
device_scalar(value, stream)ctor would copy from a host temporary that dies before the copy is guaranteed to have read it. So the value ends up being something random.xref rapidsai/rmm#2526 NVIDIA/cuml#8510